Re: Applying the inet6 ND state engine to inet4

[Jason Thorpe <thorpej%me.com@localhost>]

> On Aug 19, 2020, at 7:04 AM, Roy Marples <roy%marples.name@localhost> wrote:
> 
> Patch here: https://www.netbsd.org/~roy/netbsd-nd.diff

In tcp_input.c:nd_hint():

+	switch (tp->t_family) {
+#ifdef INET
+	case AF_INET:
+		arp_nud_hint(rt);
+		break;
+#endif
+#ifdef INET6
+	case AF_INET6:
 		nd6_nud_hint(rt);
-		rtcache_unref(rt, &tp->t_in6pcb->in6p_route);
+		break;
+#endif
 	}
+
+	rtcache_unref(rt, &tp->t_in6pcb->in6p_route);
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Shouldn't that be:

        rtcache_unref(rt, ro);

?

-- thorpej