tech-net archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: Patches fixing unaligned access in the networking code



> uint32() is a bad function name as it is a type defined in multiple
> places in the kernel.
> 
> I would pick the name get_uint32().

Why not existing be32enc(9)?
 http://netbsd.gw.com/cgi-bin/man-cgi?be32enc++NetBSD-current
>>     The be16enc(), be16dec(), be32enc(), be32dec(), be64enc(), be64dec(),
>>     le16enc(), le16dec(), le32enc(), le32dec(), le64enc(), and le64dec()
>>     functions encode and decode integers to/from octet stream on any align-
>>     ment in big/little endian format.

---
Izumi Tsutsui


Home | Main Index | Thread Index | Old Index