Re: altq on a gif tunnel

[Kengo NAKAHARA <k-nakahara%iij.ad.jp@localhost>]

Hi,

On 2018/11/09 9:01, Tho wrote:
> On Wednesday  7 Nov 2018, at 18:29, Kengo NAKAHARA wrote:
>> Could you try the following patch?
>> ====================
>> diff --git a/sys/net/if_gif.c b/sys/net/if_gif.c index
>> fa9e63d59fd..169f2013014 100644
>> --- a/sys/net/if_gif.c
>> +++ b/sys/net/if_gif.c @@ -487,7 +487,10 @@ gif_output(struct ifnet
>> *ifp, struct mbuf *m, const struct sockaddr *dst,
>>         m->m_pkthdr.csum_flags = 0;
>>         m->m_pkthdr.csum_data = 0;
>>  
>> -       error = gif_transmit_direct(var, m);
>> +       gif_putref_variant(var, &psref);
>> +       var = NULL;
>> +       error = if_transmit_lock(ifp, m);
>> +
>>  end:
>>         if (var != NULL)
>>                 gif_putref_variant(var, &psref);
>> ====================
> 
> Sorry, please ignore my previous e-mail. After another attempt, it's
> actually working. I'm not sure what I did or went wrong on the first
> attempt.
> 
> So it's working, I can see altqstat reporting traffic and even
> classifying it correctly.
> 
> Well done, thanks!

Thank you very much for your testing!
I make a little improvement and commit it as if.gif.c:r1.145.


Thanks,

-- 
//////////////////////////////////////////////////////////////////////
Internet Initiative Japan Inc.

Device Engineering Section,
IoT Platform Development Department,
Network Division,
Technology Unit

Kengo NAKAHARA <k-nakahara%iij.ad.jp@localhost>