Re: IPv6 test failures

[Robert Swindells <rjs%fdy2.co.uk@localhost>]

On 2018-04-29 14:35, Roy Marples wrote:
> On 28/04/2018 16:07, Robert Swindells wrote:
> > On 2018-04-28 15:18, Maxime Villard wrote:
> > > Le 28/04/2018 à 14:37, Robert Swindells a écrit :
> > > > Is anyone looking at the cause of these failures in recent test runs 
> > > > ?
> > > >
> > > > net/ndp/t_ra
> > > >    ra_flush_prefix_entries
> > > >    ra_prefix_expiration
> > > >
> > > > They are failing because NDP is broken, I'm seeing the same 
> > > > behaviour on my systems.
> > > >
> > > > The host receives an RA but doesn't do anything with it.
> > > >
> > > > Robert Swindells
> > >
> > > When did that stop working? I didn't touch ND6, but I did touch 
> > > ICMPv6.
> >
> > It wasn't you that broke it.
> >
> > Part of my local problem is caused by a bug in dhcpcd, I was able to 
> > toggle the
> > interface flags using ndp(8) then run a local copy of rtsol to get a 
> > prefix
> > and default route set up.
>
> Can you describe more the bug in dhcpcd?

I think you have the logic wrong for setting the interface flags.

It works for me now with this patch:

Index: if-bsd.c
===================================================================
RCS file: /cvsroot/src/external/bsd/dhcpcd/dist/src/if-bsd.c,v
retrieving revision 1.1.1.7
diff -u -r1.1.1.7 if-bsd.c
--- if-bsd.c    27 Mar 2018 06:14:39 -0000      1.1.1.7
+++ if-bsd.c    29 Apr 2018 13:37:48 -0000
@@ -1435,10 +1435,10 @@
         */
 #ifdef ND6_IFF_ACCEPT_RTADV
        if (ifp->options->options & DHCPCD_IPV6RS)
-               flags &= ~ND6_IFF_ACCEPT_RTADV;
+               flags |= ND6_IFF_ACCEPT_RTADV;
 #ifdef ND6_IFF_OVERRIDE_RTADV
        if (ifp->options->options & DHCPCD_IPV6RS)
-               flags |= ND6_IFF_OVERRIDE_RTADV;
+               flags &= ~ND6_IFF_OVERRIDE_RTADV;
 #endif
 #endif

I was just using "-6 --nodhcp6 wm0" as the arguments to dhcpcd.

The same code is in -8 so maybe need to let releng know.

> I fixed the sending of the RA in rtadvd.c 1.66 (and the tests now show
> it's sending again, yay) so I think I've not broken this either.
>
> > I suspect that I'm also having MTU mismatch problems though.
>
> Both dhcpcd and the kernel will set the MTU of the routes to the MTU
> as perscribed by the RA.

The remaining problem is IPv4 only.