tech-net archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: IPv4: __vax__



Le 21/04/2018 à 13:37, Anders Magnusson a écrit :
Hm, no idea.  Maybe it was that mbufs could end up with zero len here
(looking at the original code)?

I believe the goal of the check was to ensure that ip_insertoptions would
get a correctly 4-byte-aligned mbuf size, because it does not insert
padding to ensure 4-byte alignment.

If it's not aligned, ip_hl gets truncated and we probably end up sending
garbage on the network.

Should be OK to remove it now.

Alright, I've removed it.

Thanks,
Maxime


Home | Main Index | Thread Index | Old Index