tech-net archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: patch make struct protosw pr_input non-variadic



In article <20160513195611.GA8625@pris>,
Tyler Retzlaff  <rtr%netbsd.org@localhost> wrote:
>-=-=-=-=-=-
>
>Hi,
>
>The attached patch for review (originally produced by riastradh@)
>that provides the structural changes needed to make
>protosw::pr_input protocol-specific and ditch its variadic
>prototype pr_input(struct mbuf *, ...).
>
>Similar work has already been done & discussed.
>
>https://mail-index.netbsd.org/tech-net/2016/01/16/msg005484.html
>
>Once the structural changes are in I'll generate a second patch
>adapting the variadic implementations of pr_input to functions with
>apropriate prototypes.
>
>This patch:
>* moves pr_input out of struct protosw and places it into <proto>sw
>  specitic structure.
>* converts domain::dom_protosw to an array of pointers

Why? What's the point of the extra indirection? You could just stick
and & in front of the array element assignment.

christos




Home | Main Index | Thread Index | Old Index