Re: bridge(4)

[Ryota Ozaki <ozaki-r%netbsd.org@localhost>]

Hi,

On Sat, Aug 1, 2015 at 12:27 AM, Robert Swindells <rjs%fdy2.co.uk@localhost> wrote:
>
> Please could someone try the following patch.
>
> The deleted line shouldn't be doing anything useful in normal usage
> plus I think it can confuse wireless devices that are members of the
> bridge.

I think you're right. It seems M_PROTO1 was introduced for gif(4),
but after gif(4) update, M_PROTO1 became unnecessary.

The change doesn't break ATF tests. Let's commit it.
  ozaki-r

>
> Robert Swindells
>
> Index: if_bridge.c
> ===================================================================
> RCS file: /cvsroot/src/sys/net/if_bridge.c,v
> retrieving revision 1.100
> diff -u -r1.100 if_bridge.c
> --- if_bridge.c 23 Jul 2015 10:52:34 -0000      1.100
> +++ if_bridge.c 31 Jul 2015 15:23:18 -0000
> @@ -1512,7 +1512,6 @@
>  #endif /* ALTQ */
>
>         len = m->m_pkthdr.len;
> -       m->m_flags |= M_PROTO1;
>         mflags = m->m_flags;
>
>         IFQ_ENQUEUE(&dst_ifp->if_snd, m, &pktattr, error);