tech-net archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: Removing ifnet_addrs



Oops, I didn't notice that I already committed the patch.
I'm sorry for that.

On Tue, Jun 30, 2015 at 9:07 PM, Darren Reed <darrenr%netbsd.org@localhost> wrote:
> Looking at the patch, the comment reads:
>
>     We can assume that ifp->if_dl is the same as ifnet_addrs[ifp->if_index]
>     so we can replace ifnet_addrs[ifp->if_index] with ifp->if_dl and
>     remove ifnet_addrs entirely.
>
> The word "assume" is not very precise and suggests that you're
> not 100% sure. Either it is the same and the patch is right or it
> isn't the same and the patch is wrong. No assumptions.

They're always the same, so I should get rid of "We can assume that"...

  ozaki-r

>
> Drren
>


Home | Main Index | Thread Index | Old Index