tech-net archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: IPv4 Address Flags



On Wed, Apr 22, 2015 at 10:24:18PM +0000, Christos Zoulas wrote:
> In article <55381013.6070403%marples.name@localhost>,
> Roy Marples  <roy%marples.name@localhost> wrote:
> >diff -u -r1.188 if.h
> >--- sys/net/if.h	20 Apr 2015 10:19:54 -0000	1.188
> >+++ sys/net/if.h	22 Apr 2015 21:03:01 -0000
> >@@ -594,6 +594,7 @@
> > 		struct	sockaddr ifru_broadaddr;
> > 		struct	sockaddr_storage ifru_space;
> > 		short	ifru_flags;
> >+		int	ifru_addrflags;
> > 		int	ifru_metric;
> 
> This is an ABI change to all ifreq ioctls... If you are going to do this,
> I'd bite the bullet and bump sockaddr_storage to 256 or 512 bytes and get
> rid of sockaddr_big.

Wouldn't it be enough to make it a short for now? There should be
padding here?

Joerg


Home | Main Index | Thread Index | Old Index