Re: RTF_LOCAL support

[Roy Marples <roy%marples.name@localhost>]

On 24/02/2015 18:33, Christos Zoulas wrote:
> In article <54EC9CE0.4050405%marples.name@localhost>,
> Roy Marples  <roy%marples.name@localhost> wrote:
> 
> Bikeshed comment warning...
> 
>> Index: sys/net/route.h
>> ===================================================================
>> RCS file: /cvsroot/src/sys/net/route.h,v
>> retrieving revision 1.84
>> diff -u -p -r1.84 route.h
>> --- sys/net/route.h	6 Jun 2014 01:02:47 -0000	1.84
>> +++ sys/net/route.h	24 Feb 2015 14:00:10 -0000
>> @@ -155,7 +155,7 @@ struct ortentry {
>> #define RTF_PROTO1	0x8000		/* protocol specific routing flag */
>> #define RTF_SRC		0x10000		/* route has fixed source address */
>> #define	RTF_ANNOUNCE	0x20000		/* announce new arp or ndp entry */
>> -
>> +#define RTF_LOCAL	0x200000	/* route represents a local address */
> 
> Why 0x200000 instead of 0x40000?

It's the same value used by the other OSes, no other reason.
I note that where each has the same flag, the value is also the same,
hence keeping it the same here.

> 
>> @@ -292,22 +292,23 @@ struct rt_metrics {
>> .Pp
>> Flags include the values:
>> .Bd -literal
>> -#define	RTF_UP        0x1      /* route usable */
>> -#define	RTF_GATEWAY   0x2      /* destination is a gateway */
>> -#define	RTF_HOST      0x4      /* host entry (net otherwise) */
>> -#define	RTF_REJECT    0x8      /* host or net unreachable */
>> -#define	RTF_DYNAMIC   0x10     /* created dynamically (by redirect) */
>> -#define	RTF_MODIFIED  0x20     /* modified dynamically (by redirect) */
>> -#define	RTF_DONE      0x40     /* message confirmed */
>> -#define	RTF_MASK      0x80     /* subnet mask present */
>> -#define	RTF_CLONING   0x100    /* generate new routes on use */
>> -#define	RTF_XRESOLVE  0x200    /* external daemon resolves name */
>> -#define	RTF_LLINFO    0x400    /* generated by ARP or ESIS */
>> -#define	RTF_STATIC    0x800    /* manually added */
>> -#define	RTF_BLACKHOLE 0x1000   /* just discard pkts (during updates) */
>> -#define	RTF_CLONED    0x2000   /* this is a cloned route */
>> -#define	RTF_PROTO2    0x4000   /* protocol specific routing flag */
>> -#define	RTF_PROTO1    0x8000   /* protocol specific routing flag */
>> +#define	RTF_UP        0x1       /* route usable */
>> +#define	RTF_GATEWAY   0x2       /* destination is a gateway */
>> +#define	RTF_HOST      0x4       /* host entry (net otherwise) */
>> +#define	RTF_REJECT    0x8       /* host or net unreachable */
>> +#define	RTF_DYNAMIC   0x10      /* created dynamically (by redirect) */
>> +#define	RTF_MODIFIED  0x20      /* modified dynamically (by redirect) */
>> +#define	RTF_DONE      0x40      /* message confirmed */
>> +#define	RTF_MASK      0x80      /* subnet mask present */
>> +#define	RTF_CLONING   0x100     /* generate new routes on use */
>> +#define	RTF_XRESOLVE  0x200     /* external daemon resolves name */
>> +#define	RTF_LLINFO    0x400     /* generated by ARP or ESIS */
>> +#define	RTF_STATIC    0x800     /* manually added */
>> +#define	RTF_BLACKHOLE 0x1000    /* just discard pkts (during updates) */
>> +#define	RTF_CLONED    0x2000    /* this is a cloned route */
>> +#define	RTF_PROTO2    0x4000    /* protocol specific routing flag */
>> +#define	RTF_PROTO1    0x8000    /* protocol specific routing flag */
>> +#define	RTF_LOCAL     0x200000	/* route represents a local address */
> 
> Can you sync those with the header file?

Sure

Roy