Re: workqueue in if_bnx: static struct work * seems wrong

[Manuel Bouyer <bouyer%antioche.eu.org@localhost>]

On Thu, Mar 01, 2012 at 09:23:34AM -0700, Sverre Froyen wrote:
> On Monday 27 February 2012 02:22:20 Jean-Yves Migeon wrote:
> > On Sun, 26 Feb 2012 22:05:59 +0100, Manuel Bouyer wrote:
> > > On Sun, Feb 26, 2012 at 05:22:50PM +0100, Jean-Yves Migeon wrote:
> > >[...]
> > 
> > Yep, you are right. I just had a look at workqueue(9) implementation
> > this morning, and multiple bnx(4) instances would badly break with
> > anything besides SIMPLEQ.
> > 
> > Having a wk allocated in sc is the way to go.
> 
> Instead of every driver implementing its own memory management, would it not 
> make more sense to use an common mechanism like, e.g., pool_cache?

A pool for a single per-instance structure which is completely static
deosn't make sense. Just declare it static in the softc ...

-- 
Manuel Bouyer <bouyer%antioche.eu.org@localhost>
     NetBSD: 26 ans d'experience feront toujours la difference
--