Re: gigE negotiation failure with wm0

[SAITOH Masanobu <masanobu%iij.ad.jp@localhost>]

 Hi, all.

 > On Tue, 9 Sep 2008 17:41:57 -0400
 > Brad <brad%comstyle.com@localhost> wrote:
 > 
 > > This will not help with the problem. Looking at igphy(4) I can see it
 > > is programming DSP override values into the third generation IGP PHY
 > > which it should not. First I would make the code only call the DSP
 > > load function for the first two generations of PHY (represented by a
 > > single PHY id). Then I would also take a look at...
 > > 
 > > http://www.freebsd.org/cgi/cvsweb.cgi/src/sys/dev/e1000/e1000_phy.c
 > > 
 > > e1000_phy_init_script_igp3() and create another DSP load function for
 > > the third generation PHY and plug in those DSP values.
 > 
 > Perusing the 36,000 or so lines of code [*] in the FreeBSD driver, it
 > looks like the smart speed workarounds only apply to that first
 > generation igp, and the dsp code is not only igp-specific, but is
 > really only used when there's no EEPROM.  Given all that, is it a
 > serious problem to just remove the later generation PHYs from this file
 > altogether and let them fall through to ukphy?  That, as they say,
 > works for me on my T61.
 > 
 > RCS file: /cvsroot/src/sys/dev/mii/igphy.c,v
 > retrieving revision 1.17
 > diff -u -r1.17 igphy.c
 > --- igphy.c     17 Nov 2008 03:04:27 -0000      1.17
 > +++ igphy.c     5 Aug 2009 20:21:58 -0000
 > @@ -116,9 +116,6 @@
 >         { MII_OUI_yyINTEL,              MII_MODEL_yyINTEL_IGP01E1000,
 >           MII_STR_yyINTEL_IGP01E1000 },
 >  
 > -       { MII_OUI_yyINTEL,              MII_MODEL_yyINTEL_I82566,
 > -         MII_STR_yyINTEL_I82566 },
 > -
 >         {0,                             0,
 >          NULL },
 >  };
 > 
 > Kevin
 > kml%patheticgeek.net@localhost
 > 
 > [*] Apparently UNIX Version 6 was about 8,200 lines of C and 900 lines
 > of assembler.


 I've commit the fix for igphy and re-enabled it. Could you verify whether
that bug have been fixed? I've verified that on ICH8 and ICH9.

=================
Module Name:    src
Committed By:   msaitoh
Date:           Wed Dec 16 04:50:36 UTC 2009

Modified Files:
        src/sys/dev/mii: igphy.c
        src/sys/dev/pci: if_wm.c
Added Files:
        src/sys/dev/pci: if_wmvar.h

Log Message:
Ee-enable igphy's 82566 support.
 - Patch for the DSP code is only for 8254[17] and we have to apply the
   different patches between rev. 1 and rev. 2.
 - The workaround for analog fuse is only for 82547 rev. 1.
 - The workaround for smartspeed is only for 8254[17]

see http://mail-index.netbsd.org/tech-net/2009/08/05/msg001546.html


To generate a diff of this commit:
cvs rdiff -u -r1.18 -r1.19 src/sys/dev/mii/igphy.c
cvs rdiff -u -r1.181 -r1.182 src/sys/dev/pci/if_wm.c
cvs rdiff -u -r0 -r1.3 src/sys/dev/pci/if_wmvar.h

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
=================

----------------------------------------------------------
                SAITOH Masanobu (masanobu%iij.ad.jp@localhost
                                  msaitoh%netbsd.org@localhost)