Re: defflag'ing ipfilter options

[Darren Reed <darrenr%netbsd.org@localhost>]

Christoph Badura wrote:
> I've been annoyed for a while that most of the ipfilter options aren't
> defflag'ed into opt_ipfilter.h and one has to rm(1) Just The Right(tm)
> .o files before recompiling the kernel.  Especially to get IPFILTER_LOOKUP
> support for ippool(8).
> 
> Does anyone object to a change along the following lines?  
> 
> While there I made the inclusion of opt_ipfilter_log.h vs. opt_ipfilter.h
> depending on the same condition in all the files.
> 
> Index: netinet/files.ipfilter
> ===================================================================
> RCS file: /cvsroot/src/sys/netinet/files.ipfilter,v
> retrieving revision 1.8
> diff -u -r1.8 files.ipfilter
> --- netinet/files.ipfilter    17 Sep 2006 13:43:15 -0000      1.8
> +++ netinet/files.ipfilter    14 Dec 2009 22:36:09 -0000
> @@ -1,8 +1,14 @@
>  #    $NetBSD: files.ipfilter,v 1.8 2006/09/17 13:43:15 yamt Exp $
>  
>  defflag      opt_ipfilter.h  IPFILTER_LOG            # logging of ip packets
> +defparam     opt_ipfilter.h  IPFILTER_LOGSIZE
>  defflag      opt_ipfilter.h  IPFILTER_DEFAULT_BLOCK
> +defflag      opt_ipfilter.h  IPFILTER_CKSUM
>  defflag      opt_ipfilter.h  IPFILTER_LOOKUP
> +defflag      opt_ipfilter.h  IPFILTER_SCAN
> +defflag      opt_ipfilter.h  IPFILTER_SYNC
> +defflag      opt_ipfilter.h  IPFILTER_COMPILED
> +defflag      opt_ipfilter.h  IPFILTER_BPF
>  
>  defpseudo ipfilter: ifnet            # XXX not really an ifnet

And although it doesn't do anything much in current source,
you should add IPFILTER_COMPAT to the list above (see email
I sent a few minutes ago.)

Darren