Subject: Re: Last remaining insque / remque uses
To: Jason Thorpe <thorpej@shagadelic.org>
From: Tom Spindler <dogcow@babymeat.com>
List: tech-net
Date: 10/23/2007 21:08:39
>   File             Function       Line
> 0 systm.h          <global>       140 #define remque(q) _remque(q)
> 1 coda_namecache.h CODA_NC_HSHREM  87 #define CODA_NC_HSHREM(elem)  
> remque(elem)
> 2 coda_namecache.h CODA_NC_LRUREM  92 #define CODA_NC_LRUREM(elem)
>                                       remque(LRU_PART(elem));
> 3 if_eon.c         eonrtrequest   269 remque(&el->el_qhdr);
> 4 iso_pcb.c        iso_pcbdetach  548 remque(isop);
> 5 tp_output.c      tp_ctloutput   537 remque(tpcb);
> 6 tp_pcb.c         tp_detach      812 remque(tpcb);
> 7 tp_subr2.c       tp_route_to    659 remque(isop_new);
> 8 tp_usrreq.c      tp_usrreq      458 remque(tpcb);

Given that many of these pieces of sh^W^W^Wlovely source files
don't actually bother using 'struct queue', and far more often
monkey around with the affected structures themselves - it might
be better to just embed local copies of the routines into the
affected sources. (As the defs are all of five lines of code each,
I don't think it'd be a horrible burden.)