Subject: Re: pool/spl cleanup in netinet, netinet6, net
To: Thor Lancelot Simon <>
From: Sean Boudreau <>
List: tech-net
Date: 07/20/2006 10:14:32
On Thu, Jul 20, 2006 at 10:00:37AM -0400, Thor Lancelot Simon wrote:
> On Thu, Jul 20, 2006 at 09:46:51AM -0400, Sean Boudreau wrote:
> > 
> > I think you're missing some splx(s) below.
> I don't think so -- the two sections of the patch that you
> quoted just move existing splsoftnet() calls a couple of lines
> higher.  However, they seem to splx() the wrong variable name;
> oops!

That was the part I added to your diff (the part I think
your diff was missing).

> > Are you sure in[6]_pcbpurgeif0(), in[6]_purgeif()
> > and in[6]_pcbpurgeif() need splsoftnet()?  This
> > seems to be outside the pool issue.
> Yes, I'm sure: they can call the ICMP purge routine, which
> does pool_put.

I don't see it.  What routine exactly does the pool_put?