Subject: Re: variable length "struct ifnet" is bad
To: None <tech-net@netbsd.org>
From: Christos Zoulas <christos@astron.com>
List: tech-net
Date: 06/23/2006 16:39:25
In article <200606231609.SAA0000003406@zel459.zel.kfa-juelich.de>,
Matthias Drochner  <M.Drochner@fz-juelich.de> wrote:
>
>Hi -
>"struct ifnet" has an "#if NAGR > 0" in it. This can cause that
>it has a different length for kernel and userland. What makes it
>worse is that there are other structures (eg "struct ethercom")
>which embed "ifnet" and thus change their layout. This breaks eg
>"ifconfig -a" and "ifmcstat" for me.
>
>Just delete the "ifdef" or is there a way to make "if_agrprivate"
>really agr private?

Just delete the ifdef for now. It is not like a few bytes in struct
ifnet are going to change the world.

christos