Subject: Re: sk(4) interrupt moderation timing fix, and sysctl support
To: Jason Thorpe <thorpej@shagadelic.org>
From: Jeff Rizzo <riz@tastylime.net>
List: tech-net
Date: 11/24/2005 09:49:39
This is an OpenPGP/MIME signed message (RFC 2440 and 3156)
--------------enig24AFEE51C1B7BFEC00E96C3B
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit

Jason Thorpe wrote:

>
> On Nov 23, 2005, at 8:10 PM, Jeff Rizzo wrote:
>
>> 1. Should I bother supporting a per-board value for the interrupt 
>> moderation
>> timer?  In this patch, it's global, and only takes effect when 
>> sk_init()
>> is called. (ifconfig down/up is a good way to trigger this)
>
>
> Seems like it should be per-instance rather than global, especially 
> if different revisions of the chip need to have different values.


Well, the global value is made chip-specific before being applied to the
actual board, but I'll put together a per-instance version anyway;  I
think that's probably best.

>
>> 2. if_bge.c notes that the sysctl stuff will need to be made  dynamic to
>> support LKM loading - should I bother with this now, or take it up 
>> later?
>
>
> Burn that bridge later.

OK, thanks for the feedback.

+j


--------------enig24AFEE51C1B7BFEC00E96C3B
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (Darwin)
Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org

iQCVAwUBQ4X9N7OuUtxCgar5AQP12wP/aDlkDGhn5rnfysAAmrf8hKG1JEwq43vS
Un9SMo4JOl3Pa35YHHGAEEJqZmluvBu4bZPD59w8hysD7uag1QPpqingodeoNqHr
Ig+Ef976hHZQRYZXvcj2fm2MrWNyT1pboH2Kxn+R/EH/H0YuulC9lnBrVJYz/Szv
A2GVg4SiLyU=
=THM7
-----END PGP SIGNATURE-----

--------------enig24AFEE51C1B7BFEC00E96C3B--