--nFreZHaLTZJo0R7j
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Mar 14, 2005 at 09:04:56PM +0900, YAMAMOTO Takashi wrote:
> hi,
>=20
> can anyone review the attached patch?  thanks.
>=20
> - use full sized segments unless we actually have SACKs to send.
> - avoid TSO duplicate D-SACK.
> - send SACKs regardless of TF_ACKNOW.
> - don't clear rcv_sack_num when transmitting.
>=20

I'm unsure about "send SACKs regardless of TF_ACKNOW".  Is there any
specific reason why you want to do this?  It's implicit that we'll
be sending an ACK back when we have SACK information (as in, we received
something out of order so we will be sending a Dup-Ack back), so I
guess that the check isn't strictly neccecary, but...

--=20
Kentaro A. Kurahone
SIGUSR1 Research and Development

--nFreZHaLTZJo0R7j
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.0 (FreeBSD)

iQIVAwUBQjWFhWfp+SLSG+tuAQJTXQ/8Cl+1VOac1zLxc+8v+wK4sDSEkLjsDApo
XD88YculSBGAtu0xAfhyng5vBT+mNhTpdas3x2F/wgzFy5AZ1gIYPc8VfxsFbU0N
ZmKu139vfV9i8R6SCXdvg0Y9apejPWODThx0nqjqn8asAnaaQALFR8hjIJIJANL6
Zc8+KLh7mzOVmZ1q9TOinXpgAKlaueA/seTtEYIawiPGn8uG1rVdJF9X/5GXXKx5
3Lc000lBtQ0vIDPCDfXhcYcyPj5j26PmbZkaWZit0QklrxoiGz3BGw5hFSeiZxM7
qyshjVf16ItQIS7Qas37VRQw4ZhNFXgJxFZLzw49aTByHM55mFTMS5cD6VoytZc0
W+FqSAwAeYDtCEGFD/NLNHfku4WZ0QRYYPxoUrgBf1CurjE3uSnRz7ndF9bQ/OGU
udxVbJyi4occ4btS/nIek9/HC9mCbrtQ6l5F5rOdbkLpvmVCdNpOpfHCPXtO9Orw
O7aKgEj3DCPNR349IrsjVGbGUW6WRVUeFopVI57uNB1RlxTh46CBSsfAmGa6v/Nl
cEw7pVOhztkZ4LrQbxaeyDMzuVYu5Q+CCbma8Zuw6sYZjBWsLkOQ4ViLQdvGBJfT
Xgw+NA2wc6DLnzvBQwk9aWALTzMxFIidR7LueTQ05tS0e4Hj+n6/KKI66Q5Yrbyn
g5DDhVehgjc=
=Yc3u
-----END PGP SIGNATURE-----

--nFreZHaLTZJo0R7j--