Subject: redundant assignment or NULL dereference in in_pcbconnect()
To: None <tech-net@NetBSD.org>
From: Sean Boudreau <seanb@qnx.com>
List: tech-net
Date: 09/29/2004 10:59:42
Plus there's a window where ia is NULL here.
-seanb
Index: netinet/in_pcb.c
===================================================================
RCS file: /cvsroot/src/sys/netinet/in_pcb.c,v
retrieving revision 1.95
diff -c -r1.95 in_pcb.c
*** netinet/in_pcb.c 25 Apr 2004 16:42:42 -0000 1.95
--- netinet/in_pcb.c 29 Sep 2004 14:47:16 -0000
***************
*** 447,453 ****
if (error == EAGAIN)
return (error);
}
- inp->inp_laddr = ia->ia_addr.sin_addr;
inp->inp_laddr = ifaddr->sin_addr;
}
inp->inp_faddr = sin->sin_addr;
--- 447,452 ----