Subject: sosend sndbuf limit for nfsd
To: None <mycroft@netbsd.org>
From: YAMAMOTO Takashi <yamt@mwd.biglobe.ne.jp>
List: tech-net
Date: 03/17/2004 19:55:37
hi,

cvs log uipc_socket.c says:
> revision 1.11
> date: 1994/04/25 08:22:07;  author: mycroft;  state: Exp;  lines: +10 -10
> Minor cleanup.

however, it seems beyond a cleanup to me.
it eliminated sendbuf limit for !uio case.  for what was it needed?

i'd like to back it out so that
nfsd doesn't eat up too large memory.  (a diff attached)

YAMAMOTO Takashi


Index: uipc_socket.c
===================================================================
--- uipc_socket.c	(revision 626)
+++ uipc_socket.c	(revision 627)
@@ -783,7 +783,7 @@ sosend(struct socket *so, struct mbuf *a
 		if ((atomic && resid > so->so_snd.sb_hiwat) ||
 		    clen > so->so_snd.sb_hiwat)
 			snderr(EMSGSIZE);
-		if (space < resid + clen && uio &&
+		if (space < resid + clen &&
 		    (atomic || space < so->so_snd.sb_lowat || space < clen)) {
 			if (so->so_state & SS_NBIO)
 				snderr(EWOULDBLOCK);