Subject: Re: if_clone_lookup bogus?
To: Quentin Garnier <netbsd@quatriemek.com>
From: None <itojun@iijlab.net>
List: tech-net
Date: 08/14/2003 09:06:21
>Maybe I'm mistaken, but if_clone_lookup in sys/net/if.c looks bogus to me.
>
>Imagine the case where both ppp(4) and pppoe(4) are clonable and compiled,
>and "ppp" appears before "pppoe" in the cloners list.
>
>When requesting creation of a pppoe interface, if_clone_lookup will
>mistakenly match "ppp" and then fails because it is not followed by a
>number.
>
>I propose the following patch. It makes the thing (slightly) less
>obfuscated and make some boundary check on the name parameter.

	i think you are right.  will commit this change.

itojun