Subject: Re: kern/21696: another panic from nfsrv_commit()
To: None <bouyer@antioche.lip6.fr>
From: YAMAMOTO Takashi <yamt@mwd.biglobe.ne.jp>
List: tech-net
Date: 06/10/2003 10:34:04
hi,

> > 	Some time ago I fixed a bug in NFS commit: when the size of the
> > 	region to be commited was 0, a diagnostic check would be triggered:
> > login: panic: kernel diagnostic assertion "startoff < endoff || endoff == 0" failed: file "/home/src/sys/arch/alpha/compile/DISCO/../../../../miscfs/genfs/genfs_vnops.c", line 1041
> > 	
> > 	I got this panic again, but this time because the offset is past the
> > 	end of file. In the request that triggered this, len was 0.
> > 
> > 	The NFS specs don't say anything about out of file commit requests.
> > 	I choose to start from the beggining of file.

i think that doing nothing (i.e. just return NFS_OK to client) is
more straightforward for such requests.

YAMAMOTO Takashi