Subject: Re: getting rid of NTOHS() in ip_input()
To: Jun-ichiro itojun Hagino <itojun@iijlab.net>
From: enami tsugutomo <enami@sm.sony.co.jp>
List: tech-net
Date: 08/14/2002 10:41:03
One more.
Jun-ichiro itojun Hagino <itojun@iijlab.net> writes:
> @@ -912,9 +909,12 @@
> */
> - for (; q != NULL && ipqe->ipqe_ip->ip_off + ipqe->ipqe_ip->ip_len >
> - q->ipqe_ip->ip_off; q = nq) {
> - i = (ipqe->ipqe_ip->ip_off + ipqe->ipqe_ip->ip_len) -
> - q->ipqe_ip->ip_off;
> - if (i < q->ipqe_ip->ip_len) {
> - q->ipqe_ip->ip_len -= i;
> - q->ipqe_ip->ip_off += i;
> + for (; q != NULL &&
> + ntohs(ipqe->ipqe_ip->ip_off) + ntohs(ipqe->ipqe_ip->ip_len) >
> + ntohs(q->ipqe_ip->ip_off); q = nq) {
> + i = (ntohs(ipqe->ipqe_ip->ip_off) +
> + ntohs(ipqe->ipqe_ip->ip_len)) - ntohs(q->ipqe_ip->ip_off);
Do we need to swap ipqe->ipqe_ip->ip_{off,len} on every iteration?
enami.