Subject: Re: pppoe & mbuf chain
To: None <itojun@iijlab.net>
From: YAMAMOTO Takashi <yamt@mwd.biglobe.ne.jp>
List: tech-net
Date: 06/22/2002 16:47:00
From: itojun@iijlab.net
Subject: Re: pppoe & mbuf chain 
Date: Sat, 22 Jun 2002 16:31:20 +0900
> >> +	m_copydata(m, 0, sizeof(eh), (caddr_t)&eh);
> >> +	m_adj(m, sizeof eh);
> >any point to copy and m_adj here while you're using m_pulldown?
> 
> 	you can't reliably use pointers that points outside of
> 	[m_data, m_data + m_len].  therefore i've copied it.

i mean following.

- just off += sizeof(eh), instead of copying and m_adj.
- m_pulldown(m, 0, sizeof(eh), 0) in PPPOE_CODE_PADO processing
  (ie. when you really need ethernet header).

---
YAMAMOTO Takashi<yamt@mwd.biglobe.ne.jp>