>> >+		/* should be in a single mbuf */
>> >+		if (m->m_next != NULL) {
>> >+			m = m_pullup(m, m->m_len);
>> 	m_pullup(m, m->m_len) seems really incorrect to me (as this would
>> 	be a no-op).  the 2nd arg must be something else.
>yes, i intended m_pullup(m, m->m_pkthdr.len). :)
>thanks.

	that have high possibility of failure (if m->m_pkthdr.len > MHLEN,
	m_pullup will fail), so i'd suggest rewriting pppoe code not to require
	"single mbuf" restriction.

iotjun