Subject: Re: Patch to make upper-layer network protocols align as needed
To: Matt Thomas <matt@3am-software.com>
From: Jason R Thorpe <thorpej@wasabisystems.com>
List: tech-net
Date: 05/14/2002 15:00:13
On Sat, May 11, 2002 at 11:18:28AM -0700, Matt Thomas wrote:

 > Rather than doing
 > 
 >          if (!aligned)
 >                  m_slurp
 >          else if (too small)
 >                  m_pullup
 > 
 > I'd rather see:
 > 
 >          if (!aligned || too small)
 >                  m_slurp

Well, m_pullup() will skip allocating a new mbuf if the first mbuf has
sufficient trailingspace.  It would be nice to avoid the memory allocation
if you can...

 > Also, any reason why (eventually) m_slurp could not be substituted for
 > all current uses of m_pullup?

Well, see above.

-- 
        -- Jason R. Thorpe <thorpej@wasabisystems.com>