Subject: missing soclose() on sys_accept failure
To: None <tech-net@netbsd.org>
From: Jun-ichiro itojun Hagino <itojun@iijlab.net>
List: tech-net
Date: 02/21/2001 16:10:26
	it seems to me that sys_accept() lacks a call to soclose() on error.
	does it seem correct?

itojun


Index: uipc_syscalls.c
===================================================================
RCS file: /cvsroot/syssrc/sys/kern/uipc_syscalls.c,v
retrieving revision 1.56
diff -u -r1.56 uipc_syscalls.c
--- uipc_syscalls.c	2000/12/10 23:16:28	1.56
+++ uipc_syscalls.c	2001/02/21 07:08:09
@@ -253,6 +253,7 @@
 	if (error) {
 		fdremove(fdp, fd);
 		ffree(fp);
+		soclose(so);
 	}
 	m_freem(nam);
 	splx(s);