Subject: Re: missing soclose() on sys_accept failure
To: Jun-ichiro itojun Hagino <>
From: Charles M. Hannum <>
List: tech-net
Date: 02/20/2001 23:50:10
On Wed, Feb 21, 2001 at 04:10:26PM +0900, Jun-ichiro itojun Hagino wrote:
> 	it seems to me that sys_accept() lacks a call to soclose() on error.
> 	does it seem correct?

It certainly looks suspicious as is.

Shouldn't the FILE_UNUSE() also be moved down?  You don't want another
thread trying to use the socket while it's still being accepted.