On Tue, Nov 14, 2000 at 09:35:19AM +0100, Manuel Bouyer wrote:

 > > Yes, please.  Symmetry is good.  It also means you can eliminate
 > > #if NVLAN from the ti driver.  It also means you can eliminte that
 > > extra vlan_input_ifv() function, and replace it with a simple goto :-)
 > 
 > I'm not sure this is a good idea; we'd have to test for M_VLAN1Q 2 times:
 > one in ether_input and one in vlan_input. I don't know which one costs more.

The idea here is to try and NOT reference the vlan code directly from
ethernet drivers -- think "loadable modules".

Really, BPF needs to be addressed similarly.

-- 
        -- Jason R. Thorpe <thorpej@zembu.com>