Subject: Re: Full story on PFIL_HOOKS rearrangement
To: Aidan Cully <aidan@kublai.com>
From: None <itojun@iijlab.net>
List: tech-net
Date: 11/11/2000 13:00:35
>I note that I'm not a kernel or networking guy, and acknowledge that
>in practice this probably won't lose, but it strikes me as a mistake
>to create a void * key by typecasting integers... It looks like the
>void *'s are supposed to be globally unique? Taking the address of
>a kernel variable buys you that automatically, but by using integers,
>you'd need to verify each time you added a new integer key that it
>doesn't clash with old keys.
i don't think you have a clash with old keys. as we are using
the address of the integer (not the value itself) there will be no
collision.
>extern int _pfil_inet4_key;
>#define PFIL_INET4_KEY ((void *) &_pfil_inet4_key) <-- note ampersand
itojun