Subject: Re: Full story on PFIL_HOOKS rearrangement
To: None <thorpej@zembu.com>
From: enami tsugutomo <enami@sm.sony.co.jp>
List: tech-net
Date: 11/10/2000 17:57:59
Jason R Thorpe <thorpej@zembu.com> writes:

> ! 	TAILQ_INIT(&ph->ph_in); 

This is an unnecessary diff due to a space at the end of line.

> + int
> + fr_check_wrapper(void *arg, struct mbuf **mp, struct ifnet *ifp, int dir)
> + {
> + 	struct ip *ip = mtod(*mp, struct ip *);
> + 	int rv, hlen = ip->ip_hl << 2;
		:
> + 	rv = fr_check(ip, hlen, ifp, (dir == PFIL_OUT), mp);
> + 
> + 	HTONS(ip->ip_len);

The variable `ip' may not be a valid pointer after fr_check returns.

enami.