Subject: Re: sys/dev/ic/smc91cxx.c fix for IFF_SIMPLEX behavior
To: Jason Thorpe <thorpej@nas.nasa.gov>
From: None <itojun@iijlab.net>
List: tech-net
Date: 09/13/1999 02:48:28
>> > It only loops back to itself when in promiscuous mode?  Wow, that's sick.
>> > Change looks fine to me.
>>Actually....
>>It just occurred to me... why not just clear IFF_SIMPLEX in the driver when
>>IFF_PROMISC gets set, and then set it again when IFF_PROMISC clears?
>	I prefer to drop wrongly looped back packets and use fixed if_flags.
>	Programs may go crazy with IFF_PROMISC that goes up and down...

	(I've committed fix to smc91cxx.c already)
	I think it may be better to ensure it (drop false loopback on
	IFF_PROMISC interface) in net/if_ethersubr.c, but it will come with
	little overhead...

itojun