On Fri, Aug 06, 1999 at 12:07:58AM +1000, Darren Reed wrote:
> In some email I received from Manuel Bouyer, sie wrote:
> > I guess this change in the NetBSD tree would look like what's appended
> > below (could you check it's correct please ?).
> 
> No.  You lose nat->nat_aps being updated from ap_new_session().  It should
> look something like this:
> ...
>         if (nat->nat_aps == NULL)
>                 nat->nat_aps = ap_new_session(nat->nat_ptr->in_apr, ip,
>                                               fin, nat);
>         aps = nat->nat_aps;
>         if ((aps != NULL) && (aps->aps_p == ip->ip_p)) {
> ...

nat->nat_aps is currently not updated from ap_new_session() in the NetBSD
code.
Looking more closely, nat->nat_aps is updated inside ap_new_session(), so
I think my patch is corrent (it does all what was done before).
You should work as well, but nat->nat_aps is updated 2 times.

--
Manuel Bouyer, LIP6, Universite Paris VI.           Manuel.Bouyer@lip6.fr
--