Subject: Re: tcp window update patch
To: Jason Thorpe <thorpej@nas.nasa.gov>
From: Chris G. Demetriou <cgd@netbsd.org>
List: tech-net
Date: 02/04/1999 19:28:22
Jason Thorpe <thorpej@nas.nasa.gov> writes:
> I believe you are correct. MAtt Thomas found this and mentioned it,
> at some point, as did cgd (for Matt). I think it got botched when
> doing the -Wall changes. Please commit this fix.
The things matt noticed (from the mail i sent to jason + christos i
don't remember who else), iirc:
line 414 tcp_subr.c (1.62): i may be used w/o initialization.
diff between revs 1.22 and 1.23 of tcp_input.c, look for hunk starting
at 1122, the way it's reparenthesized is bogus.
cgd
--
Chris Demetriou - cgd@netbsd.org - http://www.netbsd.org/People/Pages/cgd.html
Disclaimer: Not speaking for NetBSD, just expressing my own opinion.