Re: Possible garbage value return in IXL

[Emmanuel Nyarko <emmankoko519%gmail.com@localhost>]

So then I guess we will need to init rv to 0.

So if the interrupt doesn’t go through the true branches, we certainly know that it’s not for us.

On 25 Mar 2025, at 1:53 PM, Manuel Bouyer <bouyer%antioche.eu.org@localhost> wrote:

On Tue, Mar 25, 2025 at 01:31:46PM +0000, Emmanuel Nyarko wrote:

https://github.com/Emmankoko/altq_refactoring_gsoc/commit/918c9c8056ccc2ed7da214bbf3c8c3cd4071fa8c?
returning garbage value · Emmankoko/altq_refactoring_gsoc@918c9c8
github.com

I don?t really understand the need of the return value in this case. But would appreciate some global reviews here.

Is a return 0 or 1 relevant to the logic here. It looks like some interrupt handling.

it is interrupt handling; return 0 if the iterrupt was not for us, 1 if it was.

Is it supposed to always return 1?

No, if we know the interrupt was not for us return 0.

--
Manuel Bouyer <bouyer%antioche.eu.org@localhost>
    NetBSD: 26 ans d'experience feront toujours la difference
--

Emmanuel