tech-kern archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: [PATCH] style(5): No struct typedefs



On Fri, Jul 14, 2023 at 12:36:30PM +0200, Johnny Billquist wrote:
> It also brings that if you want to change the definition, you change it in
> one place, and not 1000.

Only if you change the name of the struct or decide it is not going to
be a struct any more. All that is to be duplicated (from Taylor's
example upthread) is:

	struct kmutex;

> But I see that your desire is to not have a common place for definitions of
> shared things. That is certainly a choice as well.

Common things should only be defined once. There should not be
more than one declaration of struct kmutex and its members.

But multiple forward declarations (if needed) are fine.

Martin


Home | Main Index | Thread Index | Old Index