> On 13. Jul 2022, at 20:33, Taylor R Campbell <campbell+netbsd-tech-kern%mumble.net@localhost> wrote: > > Generally looks reasonable to me, assuming it passes the atf tests, > but give hannken@ another few days to review it? > > Maybe instead of adding vnode_impl.h to vfs_vnops.c, we can put the > vn_knote_* in vfs_vnode.c or create a new file vfs_knote.c, to avoid > having tentacles of vnode guts creep back into places we successfully > cut them out of before? Looks good to me, please go ahead. For me it is generally ok to include vnode_impl.h from all of kern/vfs_* miscfs/genfs/* and miscfs/specfs/*. -- J. Hannken-Illjes - hannken%mailbox.org@localhost
Attachment:
signature.asc
Description: Message signed with OpenPGP