Hi Emmanuel --I see a call to acpi_event_create_gpio but the callback doesn't do anything and the intr handler doesn't call acpi_event_notify. Can you wire the rest of that up? Should be pretty straight forward and you can use plgpio_acpi.c as an example.
Where I have seen this used, in practice, is for platforms that have their power button wired to a GPIO pin. The acpi_event framework is a way for the GPIO driver to notify firmware of the event, which in turn causes a button notification on the power button device.
Not the only use, but a common example. Other than that LGTM. Take care, Jared On Tue, 25 Jan 2022, Emmanuel Dreyfus wrote:
Hello In order to get Goodix touchscreen working, I have been working on Intel GPIO support, which I understand is required. Here is the code so fat, inspired from Linux's drivers/pinctrl/intel: ftp://ftp.netbsd.org/pub/NetBSD/misc/manu/igpio20220125.patch I had very little success for now with the touchscreen, therefore I am not even sure this code works. Is anyone in position to give it a try in another setup? Should I commit it as experimental? -- Emmanuel Dreyfus manu%netbsd.org@localhost