Re: Overhaul of I2C and SPI device autoconfiguration

[Jason Thorpe <thorpej%me.com@localhost>]

> On Sep 12, 2021, at 10:26 AM, Jason Thorpe <thorpej%me.com@localhost> wrote:
> 
> 
> 
>> On Sep 12, 2021, at 7:37 AM, Tobias Nygren <tnn%NetBSD.org@localhost> wrote:
>> 
>> iic3 at rkiic3: I2C bus
>> typec-portc (fcs,fusb302) at iic3 addr 0x22 not configured
>> panic: kernel diagnostic assertion "rv" failed: file "/usr/src/sys/dev/i2c/i2c.c", line 630
>> cpu0: Begin traceback...
>> trace fp ffffc00000f784e0
>> fp ffffc00000f78510 vpanic() at ffffc0000053bd5c netbsd:vpanic+0x14c
>> fp ffffc00000f78570 kern_assert() at ffffc0000079f928 netbsd:kern_assert+0x58
>> fp ffffc00000f78600 iic_enumerate_devices_callback() at ffffc000003448f4 netbsd:iic_enumerate_devices_callback+0xd4
>> fp ffffc00000f78670 of_i2c_enumerate_devices() at ffffc000006483cc netbsd:of_i2c_enumerate_devices+0x10c
>> fp ffffc00000f78730 device_call() at ffffc00000523e60 netbsd:device_call+0x90
> 
> Huh, ok, I’ll take a look.  I’ll craft a scenario where my DT has a “not configured” device to reproduce the problem.
> 
> Thanks for giving it a spin.  I’ll follow up shortly.

Ok, I reproduced it and found the problem pretty quickly (an errant "return false;" that was a paste-o).

<snip>
[   1.0000000] bsciic2 at simplebus1: Broadcom Serial Controller
[   1.0000000] bsciic2: interrupting on icu irq 53
[   1.0000000] iic2 at bsciic2: I2C bus
[   1.0000000] power-management (netbsd,uugear-wittypi3) at iic2 addr 0x69 not configured
[   1.0000000] /soc/vec@7e806000 at simplebus1 not configured
[   1.0000000] dwctwo0 at simplebus1: USB controller
[   1.0000000] dwctwo0: interrupting on icu irq 9
</snip>

-- thorpej