tech-kern archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: I think I've found why Xen domUs can't mount some file-backed disk images! (vnd(4) hides labels!)

kre%munnari.OZ.AU@localhost (Robert Elz) writes:

>    Date:        Sun, 11 Apr 2021 14:25:40 -0000 (UTC)
>    From: (Michael van Elst)
>    Message-ID:  <s4v0t4$5c8$>

>  | +       dg->dg_secperunit = vnd->sc_size / DEV_BSIZE;

>While it shouldn't make any difference for any properly created image
>file, make it be

>			(vnd->sc_size + DEV_BSIZE - 1) / DEV_BSIZE;

>so that any trailing partial sector remains in the image.

The trailing partial sector is already ignored. Fortunately no disk image
can even have a partial trailing sector and some magically implicit
padding would have unexpected side effects.

But the code also needs to be adjusted for different sector sizes.

Home | Main Index | Thread Index | Old Index