tech-kern archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: racy acccess in kern_runq.c

To: Kengo NAKAHARA <k-nakahara%iij.ad.jp@localhost>
Subject: Re: racy acccess in kern_runq.c
From: Andrew Doran <ad%netbsd.org@localhost>
Date: Fri, 6 Dec 2019 16:53:48 +0000

On Fri, Dec 06, 2019 at 05:22:39PM +0900, Kengo NAKAHARA wrote:

>  	/* Update the worker */
> -	worker_ci = hci;
> +	atomic_swap_ptr(&worker_ci, hci);

Why atomic_swap_ptr() not atomic_store_relaxed()?  I don't see any bug that
it fixes.  Other than that it look OK to me.

Cheers,
Andrew

Follow-Ups:
- Re: racy acccess in kern_runq.c
  - From: Maxime Villard

References:
- racy acccess in kern_runq.c
  - From: Kengo NAKAHARA
- Re: racy acccess in kern_runq.c
  - From: Maxime Villard
- Re: racy acccess in kern_runq.c
  - From: Kengo NAKAHARA

Prev by Date: Re: Changes to reduce pressure on uvm_pageqlock
Next by Date: Re: racy acccess in kern_runq.c
Previous by Thread: Re: racy acccess in kern_runq.c
Next by Thread: Re: racy acccess in kern_runq.c
Indexes:

Home | Main Index | Thread Index | Old Index