Re: netbsd32_{,u}int64 in sys/types.h for compat/sys/siginfo.h

[Rin Okuyama <rokuyama.rk%gmail.com@localhost>]

On 2019/11/19 22:59, Kamil Rytarowski wrote:
> On 18.11.2019 13:08, Rin Okuyama wrote:
> > On 2019/11/18 20:15, Kamil Rytarowski wrote:
> > > I was thinking about something along these lines:
> > >
> > > http://netbsd.org/~kamil/patch-00196-siginfo_netbsd32_compat_uint64.txt
> > >
> > > In future some compat of i386 could use 8-byte alignment for 64-bit
> > > types.
> > >
> > > Not build tested.
> >
> > Thank you for providing the patch. It looks fine for me. I committed
> > it with changes below:
> >
> > - Take into account of __arm__ && __ARM_EABI__ for compat with arm-oabi
> > - Undefine NETBSD32_SIGINFO_UINT64_ALIGN for clarity
> >
> > Thanks!
> > rin
>
> Great work!
>
> Please try to run in compat32:
>
> cd /usr/tests/lib/libc/sys
> atf-run t_ptrace* | atf-report
>
> We still miss compat32 support for PT_GETXMMREGS and PT_SETXMMREGS, at
> some point of time we shall add it for completeness.

Thank you!

With amd64/netbsd32_machdep.c rev 1.130, all tests in t_ptrace* pass in
COMPAT_NETBSD32 on amd64, except for that involved with XMM registers.
I will examine how to implement PT32_[GS]ETXMMREGS.

Also, it seems that some COMPAT_NETBSD32 related codes for amd64 need to
be cleaned up. For example, there remain COMPAT_NETBSD32 codes in
amd64/process_machdep.c, that are no longer used:

https://nxr.netbsd.org/xref/src/sys/arch/amd64/amd64/process_machdep.c#129
https://nxr.netbsd.org/xref/src/sys/arch/amd64/amd64/process_machdep.c#183
...

I will examine them too.

Thanks,
rin