On 2019/10/01 18:46, Jared McNeill wrote:
On Mon, 30 Sep 2019, Rin Okuyama wrote:http://gnats.netbsd.org/54395 With the patch attached in the PR, that KASSERT does no longer fire on aarch64 with 32-bit binaries, as far as I can see. Also, the patched kernels just work for me on amd64, earm, and m68k.I have been running with the patch in this PR doing bulk builds on arm64 for both arm64 and armv7 in parallel and the KASSERT no longer fires for me either. Nicely done!
Thank you for testing the patch!
I updated the patch in accordance with comments by uwe and joerg:
http://www.netbsd.org/~rin/uvm_map_20191002.patch
Here's a summary of changes --- mostly no functional changes:
- Turn ALIGN_VA() macro into inline function align_va().
- Use proper macros, round{up,down}2(9).
- Make sure that alignment is power of 2 in uvm_map_space_avail().
I will commit the revised patch, and send a pullup request in
the weekend, if there's no objections.
Thanks,
rin