re: [PATCH 1/2] compat32: translate userland PT_* request values into kernel

[matthew green <mrg%eterna.com.au@localhost>]

thanks for working on this.

> +	case PT_FIRSTMACH + 0:
> +		return PT_STEP;
> +	case PT_FIRSTMACH + 1:
> +		return PT_GETREGS;
[ ... ]

these magic numbers are a little ugly.  can you avoid them?
is there a way to have amd64 have direct access to the i386
values?

> --- a/sys/sys/ptrace.h
> +++ b/sys/sys/ptrace.h
> @@ -283,6 +283,10 @@ int	ptrace_machdep_dorequest(struct lwp *, struct lwp *, int,
>  #define FIX_SSTEP(p)
>  #endif
>  
> +#ifndef PTRACE_TRANSLATE_REQUEST32
> +#define PTRACE_TRANSLATE_REQUEST32(x) x
> +#endif
> +

can this part live in sys/compat(/netbsd32)?  no need for the
public ptrace header to get this, right?


.mrg.