tech-kern archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: enhance sysctl kern.expose_address




> On Dec 5, 2018, at 8:38 AM, Jason Thorpe <thorpej%me.com@localhost> wrote:
> 
> 
> 
>> On Dec 5, 2018, at 8:27 AM, Christos Zoulas <christos%zoulas.com@localhost> wrote:
>> 
>> 
>> This patch:
>> 
>> https://www.netbsd.org/~christos/kmem_expose_address.diff
> 
> PK_KMEM should only be set if mm_open returns 0.  There's a case where mm_md_open can return an error and PK_KMEM is still set.

...also it looks like the kauth callback doesn't handle the "2" case of "everyone can see".

Also, I think the sysctl should validate that the value being set is one of the allowed values { 0, 1, 2 }.

-- thorpej



Home | Main Index | Thread Index | Old Index