Re: panic: ffs_snapshot_mount: already on list

[Manuel Bouyer <bouyer%antioche.eu.org@localhost>]

On Wed, Sep 12, 2018 at 03:35:13AM +0200, Emmanuel Dreyfus wrote:
> Greg Troxel <gdt%lexort.com@localhost> wrote:
> 
> > But also, it seems that there was something wrong with this filesystem,
> > but fsck didn't fix it.  That seems like the most important thing to
> > fix.
> 
> Or there is something wrong with ffs_snapshot_mount, which panics where
> it could just ignore the duplicate snapshot?

Yes, IHMO it should not panic but complains and ignore the invalid snapshots.
In your case you had to mount the FS read/write to fix the problem
(I guess you could have fixed it with fsdb+fsck too, but we should not have
to go there to go back to a mountable filesystem).

-- 
Manuel Bouyer <bouyer%antioche.eu.org@localhost>
     NetBSD: 26 ans d'experience feront toujours la difference
--