On 08.07.2018 12:01, Martin Husemann wrote:
> On Sat, Jul 07, 2018 at 09:35:16PM +0000, Kamil Rytarowski wrote:
>> Module Name: src
>> Committed By: kamil
>> Date: Sat Jul 7 21:35:16 UTC 2018
>>
>> Modified Files:
>> src/sys/arch/amd64/include: tss.h
>> src/sys/arch/i386/include: tss.h
>>
>> Log Message:
>> Correct unportable signed integer left shift in i386/amd64 tss code
>
> This change itself is OK, but your reasoning is broken. What do you
> want to port the MD i386/amd64 code to?
>
> This is unecessary churn for no good reason, please stop it.
>
> But worse are the other changes you are doing where kubsan insists on
> natural alignement for {u,}int_{16,32,64} types, which is plain wrong,
> these CPUs do not require that alignment (and it is not even clear
> if kubsan propagates the alignment of structures correctly).
>
> Martin
>
I've started a thread on it in tech-kern@. Please move the discussion there.
Attachment:
signature.asc
Description: OpenPGP digital signature