tech-kern archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

re: setting DDB_COMMANDONENTER="bt" by default



> >> eg, make it look like, with new "dumpstack" sysctl, defaults
> >> to value of 1:
> >>
> >>   if (dumpstack > 0)
> >>      do current dumpstack method
> >>   if (onpanic > 0)
> >>      enter ddb
> >>   reboot
> >>
> >> (this idea came from jmcneill@.)
> > 
> > I'll take a look.

thanks for taking a look :)

> Like so? (haven't dealt with documentation yet)
> https://www.netbsd.org/~sevan/patch-netbsd-ddb-dumpstack.txt

i think you need to move the } above the return before
the if (db_onpanic > 0) block.  right now, db_dumpstack
is not set, Debugger() will never be called.

rest LGTM.


.mrg.


Home | Main Index | Thread Index | Old Index