tech-kern archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: RFC: PERCPU_LIST to fix PR kern/52515

To: tech-kern%netbsd.org@localhost
Subject: Re: RFC: PERCPU_LIST to fix PR kern/52515
From: Edgar Fuß <ef%math.uni-bonn.de@localhost>
Date: Mon, 11 Dec 2017 11:55:27 +0100

>  struct psref {
> -	LIST_ENTRY(psref)		psref_entry;
> +	SLIST_ENTRY(psref)		psref_entry;
> +	/* To keep ABI with LIST_ENTRY(psref) version. */
> +	void				*psref_unused0;
Isn't it somewhat fishy to manally pad this, knowing how big a [S]LIST_ENTRY 
is? Wouldn't it be cleaner to use a union?

Follow-Ups:
- Re: RFC: PERCPU_LIST to fix PR kern/52515
  - From: Taylor R Campbell

References:
- Re: RFC: PERCPU_LIST to fix PR kern/52515
  - From: Taylor R Campbell
- Re: RFC: PERCPU_LIST to fix PR kern/52515
  - From: Kengo NAKAHARA

Prev by Date: Re: RFC: PERCPU_LIST to fix PR kern/52515
Next by Date: Merging ugen into the usb stack
Previous by Thread: Re: RFC: PERCPU_LIST to fix PR kern/52515
Next by Thread: Re: RFC: PERCPU_LIST to fix PR kern/52515
Indexes:

Home | Main Index | Thread Index | Old Index