Re: RFC: vlan(4) use pkthdr instead of mtag

[Joerg Sonnenberger <joerg%bec.de@localhost>]

On Tue, Sep 19, 2017 at 02:33:12PM +0900, Shoichi YAMAGUCHI wrote:
> Thank you for the comments.
> 
> I updated the patch:
> https://gist.githubusercontent.com/s-ymgch228/6597cfc4b6f79c6c62fcdf25003acb55/raw/8237c14badb390355613794f5e3dee92431a89d2/vlan_mtag.patch
> https://gist.githubusercontent.com/s-ymgch228/6597cfc4b6f79c6c62fcdf25003acb55/raw/7169afbe597f3fb562cdc6afc4ef9caaa04d2542/vlan_mtag.patch.diff

Thanks for the update. Looking through it:

I'd still rename VLAN_TAG_VALUE to vlan_get_tag() for consistency with
the rest.

pq3etsec_tx_offload has a weird empty branch, but that's not new. 

cxgb_sge.c's t3_encap should not predicate the VLAN support.

if_ti.c's ti_rxeof is using the wrong mask now, if I interprete the
comment correctly?

Joerg